Pushover Plugin - push notifications

[marceltrapman]

@vtmikel I assume Ya is me

I think so, he asked me to fork his code and create a pull request.
I am now waiting for approval or comments.

[hequinn]

Looks like it is getting closer to be able to download and use. Good stuff!

[haavarda]

I am seeing an error when I try to use this plugin.
I have just started to test it, but I have been using pushover on Vera before...

Pushover Error Error in plugin execution ExecuteAction:

Traceback (most recent call last):
File "plugin.py", line 34, in send
File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/urllib.py", line 1262, in urlencode
<type 'exceptions.UnicodeEncodeError'>: 'ascii' codec can't encode character u'\xe5' in position 6: ordinal not in range(128)


Any thoughts on what this could be?

[jay (support)]

I don't know for sure, but it appears that some text in your notification has a non-ascii character in it and the plugin doesn't seem to like it. I'd look through your send action and see if you can spot the offending character. Look for smart quotes - those always get me.

[haavarda]

Ah...
Thank you. It was a nordic character that was doing it.
When I removed the character the push notifications started coming in.

regards

[flic]

Any news on this? I'd love to be able to select which device gets what alert.

By the way, any chance that it can be made to handle the full utf-8 character set so that us poor suckers with lots of rings and umlauts in our alphabets can use it?

[flic]

Any news on this? I'd love to be able to select which device gets what alert.

By the way, any chance that it can be made to handle the full utf-8 character set so that us poor suckers with lots of rings and umlauts in our alphabets can use it?

Never mind, found the Github repository. BTW, I fixed the UTF-8 problem and sent a push request (for all two lines of code... )

[earache]

Any updates on this?

[marceltrapman]

Never mind, found the Github repository. BTW, I fixed the UTF-8 problem and sent a push request (for all two lines of code... )

Nope, you did not find the Github repository. You forked my version of the plugin which is also a fork of the original project.

[marceltrapman]

I noticed that the developer of the plugin did not blog for 3 months either.

I suggest that we give him some additional time but I am more than willing to take over the plugin.
It means I will (have to) make some changes to the code base though.
There are some things that I would have done differently

[haavarda]

I agree. It is to bad if the development off the plugin stops... I have unofficially added priority, retry and timeout to the plugin. It is to bad to not take advantage of the possibilities that is available in the API..

Håvard


Sent from my iPhone using Tapatalk

[marceltrapman]

I agree. It is to bad if the development off the plugin stops... I have unofficially added priority, retry and timeout to the plugin. It is to bad to not take advantage of the possibilities that is available in the API.

When you send me a pm with your version of the plugin (or only the changes you made) I will add them to my version of the plugin and make it available on github.

Or, even better, you fork my version of the plugin on github and commit your changes. You can find it here: https://github.com/IT2BE/indigo-pushover

[flic]

Nope, you did not find the Github repository. You forked my version of the plugin which is also a fork of the original project.

Not sure I understand you here. I wanted your version of the plugin with the extra functionality that you added. Isn't that what I found?

[marceltrapman]

Yes, that is what you found but it is an unofficial and (to date) unsupported version of the plugin.

At this point I think it is still far better to hope for the original developer to 'come back' and add our changes than to make a second version of the plugin.

In other words I did not do anything with what you committed yet (was not even aware of them but that is my mistake).
On a side note, I also added utf8 support but did not yet commit it.

[marceltrapman]

OK, so this is what I did:

- I added a bit of error checking to the plugin before a message is sent.
- I added support for utf8 encoding (thank you for the suggestion @flic, although I moved encoding up a bit).
- I added support for priorities (thank you for the code snippets @haavarda, you will see that I used it as a suggestion and greatly enhanced what you had )

You can download the plugin here https://github.com/IT2BE/indigo-pushover but please read the installation instructions because you have to rename the folder before you can use it.

I have not tested the error checking and the use of priorities so, when something is wrong, please report an issue in the repository.