Page 1 of 1

Potential bug - manual update

PostPosted: Wed Dec 05, 2018 7:34 am
by mat
Dave,

Hope all is good with you. Downloaded the plugin at the weekend and really enjoying seeing my data in visual form. Current version I have is 0.7.07.

I think I have found a bug, and can replicate.

Selecting Manual update is updating the CSV file every 15 seconds with no schedule or trigger to update yet created.

For reference this is the second csv device created, as my first updates every 5 minutes..

Create a new csv device and select "manual update"
Add a name and a variable to the data list ie add name, id and data in the fields and add item
Save
the csv data now updates every 15 seconds without any further actions, schedule or tiggers etc.

Thanks


Mat

Re: Potential bug - manual update

PostPosted: Wed Dec 05, 2018 8:05 am
by DaveL17
mat wrote:
I think I have found a bug, and can replicate.

Selecting Manual update is updating the CSV file every 15 seconds with no schedule or trigger to update yet created.

Thanks for the report Mat. It's entirely possible that a recent update introduced a bug in CSV Engine update scheduling. I'll have a look and will see what I can find.

Cheers,
Dave

Re: Potential bug - manual update

PostPosted: Wed Dec 05, 2018 9:37 am
by mat
Thanks Dve,

If you need any reports etc, please let me know.

:)

Re: Potential bug - manual update

PostPosted: Thu Dec 06, 2018 7:19 am
by DaveL17
Hi Mat - I've had a chance to investigate and this looks like more than just a bug.

I had originally included the option to set a chart refresh interval to manual only, and it seems that I included a manual refresh entry on the CSV Engine device configuration as an oversight--there is no way to call for a manual refresh of a CSV Engine Device. This shouldn't be too heavy of a lift, and I'll try to get an update out as quickly as I can.

Sorry for the confusion.

Re: Potential bug - manual update

PostPosted: Thu Dec 06, 2018 8:43 am
by mat
Dave,

Glad you found it.

No hurry whatsoever, I'm keeping a written tally so I can manually update a csv file at some point :)

Thanks very much :)

Really enjoying having some graphs back again. thanks

Re: Potential bug - manual update

PostPosted: Fri Dec 14, 2018 5:12 pm
by DaveL17
Mat - I have updated the plugin to allow for manual refreshes of CSV devices. There are two new Action items:

v0.7.08
  • Manual Refresh - CSV Device --> Adds Action item to update CSV device set to manual update only (updates all CSV sources for selected device).
  • Manual Refresh - CSV Source --> Adds Action item to update CSV device set to manual update only (updates selected CSV data source for selected device).

Known issue: If you create one of these new Actions, changing the name of the CSV source in the CSV Engine device will break the link in the Action. You will need to go into the Action and update its target.

If you're comfortable giving it a try, you'll need to pull it off the GitHub repo by selecting 'Clone or Download', and then 'Download ZIP'.

If you choose to give it a go, please let me know how you get on.

Screen Shot 2018-12-14 at 5.04.27 PM.png
Screen Shot 2018-12-14 at 5.04.27 PM.png (21.66 KiB) Viewed 723 times

Re: Potential bug - manual update

PostPosted: Sat Dec 15, 2018 7:16 am
by DaveL17
v0.7.09 is now available, which should address the issue where changing a CSV source name breaks the Action item. Actions should no longer break when sources are renamed.

If you're comfortable giving it a try, you'll need to pull it off the GitHub repo by selecting 'Clone or Download', and then 'Download ZIP'.

Re: Potential bug - manual update

PostPosted: Sun Dec 16, 2018 5:51 am
by DaveL17
I've gone ahead and published v0.7.09 to the Indigo Plugin Store.

Re: Potential bug - manual update

PostPosted: Sun Dec 16, 2018 12:25 pm
by mat
Sorry Dave, I've been away for a week, will give it a go tomorrow night.

Thanks for working on this, as ever.

Cheer and thank you.


Mat

Re: Potential bug - manual update

PostPosted: Sun Dec 16, 2018 1:04 pm
by DaveL17
mat wrote:
Sorry Dave, I've been away for a week, will give it a go tomorrow night.

Thanks for working on this, as ever.

Cheer and thank you.


Mat

No worries whatsoever. Holidays tend to happen to people this time of year!

Re: Potential bug - manual update

PostPosted: Tue Jan 01, 2019 11:47 pm
by mat
Hi Dave,

Thanks for the update, I only got around to looking at it yesterday, but all appears working perfectly. Will let you know if any issues. Thanks for your time.

Cheers


Mat

Re: Potential bug - manual update

PostPosted: Wed Jan 02, 2019 5:53 am
by DaveL17
Thanks Mat for letting me know.

Happy New Year!

Re: Potential bug - manual update

PostPosted: Wed Jan 02, 2019 6:12 am
by mat
Happy new year to you too :)

Re: Potential bug - manual update

PostPosted: Fri Jan 11, 2019 2:36 am
by mat
Morning Dave,

Working perfectly thanks - its a daily graph and wanted to give it a few days to double check - thanks again for the input and time.

Mat

Re: Potential bug - manual update

PostPosted: Fri Jan 11, 2019 6:03 am
by DaveL17
mat wrote:
Morning Dave,

Working perfectly thanks - its a daily graph and wanted to give it a few days to double check - thanks again for the input and time.

Mat

Thanks for reporting back, Mat. Glad to hear that the update is working for you.

I have another big update coming to the plugin coming soon.