Page 1 of 1

Error on saving config

PostPosted: Sat Jan 06, 2018 8:55 pm
by MattDinOC
I'm new to homebridge and HBB, but not new to Indigo. :) I am trying to set up HBB, and running across this error when I try to save my HBB config:

Code: Select all
Jan 6, 2018, 6:44:45 PM
   EPS - Homebridge Buddy          Building configuration for 'Indigo'
   EPS - Homebridge Buddy         

#####################################################################
# SUMMARY                                                           #
#####################################################################
#                                                                   #
# Devices for Homebridge to parse          : 52                     #
# Included devices that Homebridge can use : 25                     #
# Devices over 99 that won't work          : 0                      #
#                                                                   #
#####################################################################

   EPS - Homebridge Buddy Debug    {
   "bridge": {
      "name": "Indigo",
      "username": "CC:22:3D:E3:CE:30",
      "port": 51826,
      "pin": "031-45-154"
   },

   "description": "Homebridge-Indigo configuration generated by EPS Homebridge Buddy on 2018-01-06 18:44:45 for device Indigo",

   "platforms": [
      {
         "platform": "Indigo",
         "name": "Indigo",
         "protocol": "http",
         "host": "127.0.0.1",
         "port": "8176",
         "path": "",
         "username": "[redacted]",
         "password": "[redacted]",
         "includeActions": true,
         "includeIds": ["614745064", "588283228", "228456643", "1784269267", "1498623590", "1791206213", "1667134434", "1000876139", "14940856", "1839069720", "275557157", "1111393994", "815750184", "410861352", "346408797", "402980985", "427876900", "1648819275", "1430328283", "272073437", "843886362", "1849999791", "1887545500", "135502029", "1317646674"],
         "thermostatsInCelsius": false,
         "accessoryNamePrefix": ""
      }
   ],

   "accessories": [
   ]
}
   EPS - Homebridge Buddy Error    Exception in plugin.homebridgeSaveConfig line 1622: Expecting , delimiter: line 20 column 22 (char 436)
                      CODE: json_data = json.loads(config)


I'm running the latest Indigo (7.1.1) and HBB (1.0.1) releases. Anything I can do on my end to resolve this? Or is it a bug in the plugin code?

Thanks!
Matt

Re: Error on saving config

PostPosted: Sun Jan 07, 2018 8:49 am
by Colorado4Wheeler
It's a bug, I can see it in your config where it added a comma to look for another platform. That's a tricky part of the code that has been problematic to work around and needs to be redone (on the list). In the meantime you can turn on the iTunes option for your server as it will plug the hole until I release an update as it'll add another platform there.

Re: Error on saving config

PostPosted: Sun Jan 07, 2018 8:56 am
by Colorado4Wheeler
Matt, you can also try downloading the latest dev release from Git, work was already done in that section a couple of times and likely resolved the issue.

Re: Error on saving config

PostPosted: Sun Jan 07, 2018 4:35 pm
by MattDinOC
Thanks for the quick response! I tried turning on iTunes, and then installed the dev build, but neither seems to help. Here's the current log when I try to save the config:

Code: Select all
Jan 7, 2018, 2:32:54 PM
   EPS - Homebridge Buddy          Building configuration for 'Indigo'
   EPS - Homebridge Buddy         

#####################################################################
# SUMMARY                                                           #
#####################################################################
#                                                                   #
# Devices for Homebridge to parse          : 52                     #
# Included devices that Homebridge can use : 25                     #
# Devices over 99 that won't work          : 0                      #
#                                                                   #
#####################################################################

   EPS - Homebridge Buddy Debug    {
   "bridge": {
      "name": "Indigo",
      "username": "CC:22:3D:E3:CE:30",
      "port": 51826,
      "pin": "031-45-154"
   },

   "description": "Homebridge-Indigo configuration generated by EPS Homebridge Buddy on 2018-01-07 14:32:54 for device Indigo",

   "platforms": [
      {
         "platform": "Indigo",
         "name": "Indigo",
         "protocol": "http",
         "host": "127.0.0.1",
         "port": "8176",
         "path": "",
         "username": "[redacted]",
         "password": "[redacted]",
         "includeActions": true,
         "includeIds": ["614745064", "588283228", "228456643", "1784269267", "1498623590", "1791206213", "1667134434", "1000876139", "14940856", "1839069720", "275557157", "1111393994", "815750184", "410861352", "346408797", "402980985", "427876900", "1648819275", "1430328283", "272073437", "843886362", "1849999791", "1887545500", "135502029", "1317646674"],
         "thermostatsInCelsius": false,
         "accessoryNamePrefix": ""
      },
      {
         "platform": "iTunes"
      }
   ],

   "accessories": [
   ]
}
   EPS - Homebridge Buddy Error    Exception in plugin.homebridgeSaveConfig line 1694: Expecting , delimiter: line 20 column 22 (char 436)
                      CODE: json_data = json.loads(config)


Thanks!
Matt

Re: Error on saving config

PostPosted: Sun Jan 07, 2018 4:38 pm
by MattDinOC
Oh and for completeness:

Code: Select all
Jan 7, 2018, 2:37:32 PM
   EPS - Homebridge Buddy         

#####################################################################
# EPS - Homebridge Buddy                                            #
#####################################################################
#                                                                   #
# Plugin Version      : 1.0.6                                       #
# Template Version    : 3.2.1                                       #
# Core Engine Version : 2.3.1                                       #
# Indigo Version      : 7.1.1                                       #
# Indigo API Version  : 2.0                                         #
#                                                                   #
# Alphas, Betas and Pre-Releases can be downloaded from:            #
#    https://github.com/Colorado4Wheeler                            #
#                                                                   #
# All support inquiries, questions or comments go to:               #
#    http://forums.indigodomo.com/viewforum.php?f=192               #
#                                                                   #
# Copyright (c) 2018 - Colorado4Wheeler & EPS                       #
#                                                                   #
#####################################################################

Re: Error on saving config

PostPosted: Sun Jan 07, 2018 5:24 pm
by MattDinOC
OK, great news! I found the problem! My Indigo server password contains a double-quote character. Since I "cleverly" redacted that info from my log dump that I posted here, there was no way you could have known that. I have now updated my password to remove that double-quote, and I'm past the error. This is a perfectly fine solution for me. :)

So I guess you might want to add a low-priority enhancement to your list to handle such cases, in case anyone runs into the same error in the future.

Thanks again for the help!

Matt

Re: Error on saving config

PostPosted: Mon Jan 08, 2018 9:20 am
by Colorado4Wheeler
Yup, that would do it all right. I've added it to the wish list for a future release to test for that condition.