Just getting around to test driving the plugin. Been distracted working on a few updates myself.
Love the plugin Mike. It's coming along well. A couple things I noticed, however:
1. Because I live my life in the .../Plugins folder, I of course copied the RGBColours.txt file to the wrong folder. I wasn't paying attention. This resulted in an exception to the log:
- Code: Select all
Traceback (most recent call last):
File "plugin.py", line 1414, in colourPick
File "plugin.py", line 131, in presetColours
<type 'exceptions.IOError'>: (2, 'No such file or directory', '/Library/Application Support/Perceptive Automation/Indigo 6/Preferences/Plugins/RGBColours.txt')
At a minimum, I think this would be a candidate for a trap, but I'd suggest a different route. You could make this file a component of the plugin package, and then you could get rid of the step requiring a separate install of the RGBcolours.txt file altogether. Then, if you later wanted to add more colors, you could update the file with the next plugin release.
2. I installed the plugin using an Indigo client that is not on the server machine and this doesn't work with one of the features of the plugin UI (the color picker.) No problem, but I'd suggest a note in the UI that alerts the user to the fact that the colour picker is going to appear on the server machine and not the client machine. I'm slow, so it took me a minute to figure this out.
3. It was a race to pick a color with the color picker. If I didn't pick very quickly, the plugin would timeout.
4. When I open the device configuration dialog, I get about 100 of these:
- Code: Select all
Fibaro Light Manager RGB
Fibaro Light Manager RGB
Fibaro Light Manager RGB
Fibaro Light Manager RGB
Fibaro Light Manager RGB
Fibaro Light Manager RGB
I'd suggest getting rid of this logging, or at least adding a debug level to it.
5. There is no number 5.
6. You repeatedly misspelled the word "color".
Really nice job. Keeping it going Mike!
Dave