Display Units

Posted on
Tue Mar 13, 2018 12:00 pm
Monstergerm offline
Posts: 120
Joined: Sep 01, 2009

Display Units

I think these are items that got lost/modified during the v1 to v7 transition:


Rain fall amount units specified under device setup are omitted for all Rain Amount - Day 1 (Day 2 etc.) variables.

Posted on
Wed Mar 14, 2018 12:28 pm
DaveL17 offline
User avatar
Posts: 3909
Joined: Aug 20, 2013

Re: Display Units

Sorry for the delay in responding—I’m out of town for work.

I appreciate the head’s up on this. It’s obviously not an intentional change and I’ll definitely look into it. I’ve been in the code for this plugin, so the timing is perfect. I suspect it’s a bug that came up in the transition to the way I ship state changes to the Indigo server under API 2.0.


Sent from my iPhone using Tapatalk

I came here to drink milk and kick ass....and I've just finished my milk.

[My Plugins] - [My Forums]

Posted on
Wed Mar 14, 2018 1:15 pm
Monstergerm offline
Posts: 120
Joined: Sep 01, 2009

Re: Display Units

No rush at all, this is just minor thing.
I think it has to do with rainUnits versus rainAmountUnits. The unit display on the weather device and hourly device is fine. But on the 10-day device no units are shown.

Posted on
Wed Mar 14, 2018 1:23 pm
DaveL17 offline
User avatar
Posts: 3909
Joined: Aug 20, 2013

Re: Display Units

I’m going to take a deeper dive on this.

At some point, I moved this preference from the plugin config (to affect all plugin devices) to device specific settings for folks that might want to do different units for different devices. In looking at the code now, I think it could be simplified (and fixed in this case)


Sent from my iPhone using Tapatalk

I came here to drink milk and kick ass....and I've just finished my milk.

[My Plugins] - [My Forums]

Posted on
Wed Mar 14, 2018 7:29 pm
DaveL17 offline
User avatar
Posts: 3909
Joined: Aug 20, 2013

Re: Display Units

Monstergerm wrote:
I think it has to do with rainUnits versus rainAmountUnits.

That is precisely right. I had an overly aggressive try block that was always returning no units for the 10-day device. Will be fixed in the upcoming release.

Thanks for letting me know.

I came here to drink milk and kick ass....and I've just finished my milk.

[My Plugins] - [My Forums]

Page 1 of 1

Who is online

Users browsing this forum: No registered users and 1 guest