Preferred way to timeout a function call ?

I'm checking the On / Off status of a remote piece of hardware (TV). It's a direct connection to the IP, so when the TV isn't on it hangs and eventually throws an exception. It takes about 60 seconds. It works, but it takes too long.

I'd like to force a timeout after 5 seconds so other devices don't hang. What's the preferred way to do that? Here's my function call :

Code: Select all

try:
         tv = samsungtvws.SamsungTVWS(host=ipaddress, port=8002, token_file=token_file)
         info = tv.rest_device_info()
         tvState = info['device']['PowerState']
         self.logger.debug(tvState)
      except Exception as m:
         #self.logger.debug("Error when accessing device: " + str(m))
         self.logger.debug("Could be off. Skipping...")
         device.updateStateOnServer("status", "off")
         device.updateStateImageOnServer(indigo.kStateImageSel.SensorOff)
         return



I tend to use threads for such things. Start the function call in a thread and join it after X time. I don't know if that's necessarily the preferred way, but I've had good success.

https://docs.python.org/3.10/library/th ... hread.join

Looking at the code for the library you're using, there's actually a timeout parameter you could use:

Code: Select all

class SamsungTVWS(connection.SamsungTVWSConnection):
    def __init__(
        self,
        host: str,
        token: Optional[str] = None,
        token_file: Optional[str] = None,
        port: int = 8001,
        timeout: Optional[float] = None,
        key_press_delay: float = 1,
        name: str = "SamsungTvRemote",
    ) -> None:


So maybe just try:

Code: Select all

try:
         tv = samsungtvws.SamsungTVWS(host=ipaddress, port=8002, token_file=token_file, timeout=3.0)
         info = tv.rest_device_info()
         tvState = info['device']['PowerState']
         self.logger.debug(tvState)
      except Exception as m:
         #self.logger.debug("Error when accessing device: " + str(m))
         self.logger.debug("Could be off. Skipping...")
         device.updateStateOnServer("status", "off")
         device.updateStateImageOnServer(indigo.kStateImageSel.SensorOff)
         return



Well spotted. It's too bad more libraries don't have that option.

Wow. Good lookin out. That worked perfectly. Thanks!