Clearing deviceFIlter Attribute from Actions.xml

Posted on
Sun Dec 11, 2016 7:30 pm
DaveL17 offline
User avatar
Posts: 6753
Joined: Aug 20, 2013
Location: Chicago, IL, USA

Clearing deviceFIlter Attribute from Actions.xml

I was doing some tests and included a deviceFilter with an Action Item. This worked as expected in the Indigo UI. I later removed the deviceFilter, but when I created a new action, Indigo still asked me to specify a device. Reloading the plugin, stopping the plugin and stopping the server didn't reset the behavior. I had to assign a new ID to the Action in Actions.xml and reload to get it to revert. I was then able to go back to the old ID. Is there something I missed or is this an undocumented feature? :D

I came here to drink milk and kick ass....and I've just finished my milk.

[My Plugins] - [My Forums]

Posted on
Sun Dec 11, 2016 9:46 pm
matt (support) offline
Site Admin
User avatar
Posts: 21417
Joined: Jan 27, 2003
Location: Texas

Re: Clearing deviceFIlter Attribute from Actions.xml

I would have expected a plugin reload to pull in the change/revert from XML. The Indigo Client might have cached the XML though, so it is possible an Indigo client quit/relaunch would be needed. I'm surprised the Indigo Server restart didn't work though. The ConfigUI details (like deviceFilter) in the plugin XML isn't saved in the database though, so I'm pretty sure an Indigo Client and Server restart will definitely get it reloaded.

Image

Posted on
Sun Dec 11, 2016 9:57 pm
DaveL17 offline
User avatar
Posts: 6753
Joined: Aug 20, 2013
Location: Chicago, IL, USA

Re: Clearing deviceFIlter Attribute from Actions.xml

Thanks Matt -- I don't think I tried restarting the client.

I came here to drink milk and kick ass....and I've just finished my milk.

[My Plugins] - [My Forums]

Posted on
Mon Dec 12, 2016 7:04 am
DaveL17 offline
User avatar
Posts: 6753
Joined: Aug 20, 2013
Location: Chicago, IL, USA

Re: Clearing deviceFIlter Attribute from Actions.xml

Just to follow up on this, restarting the client worked. So if I've got this right, if we push a plugin update that removes the deviceFilter from an Action, the best way to ensure that the user doesn't continue to see the filter after updating is to rename the Action ID or to instruct the user to stop the server and exit the client after updating?

I came here to drink milk and kick ass....and I've just finished my milk.

[My Plugins] - [My Forums]

Posted on
Mon Dec 12, 2016 9:25 am
matt (support) offline
Site Admin
User avatar
Posts: 21417
Joined: Jan 27, 2003
Location: Texas

Re: Clearing deviceFIlter Attribute from Actions.xml

I'd probably just tell them to quit and relaunch the Indigo client after installing the updated plugin (I think the Indigo Server probably doesn't need to be restarted). I'll add to my bug list to get the client's cache updated when the plugin refreshes, so this isn't a long term problem.

Image

Posted on
Mon Dec 12, 2016 10:09 am
DaveL17 offline
User avatar
Posts: 6753
Joined: Aug 20, 2013
Location: Chicago, IL, USA

Re: Clearing deviceFIlter Attribute from Actions.xml

Thanks Matt!


Sent from my iPhone using Tapatalk

I came here to drink milk and kick ass....and I've just finished my milk.

[My Plugins] - [My Forums]

Posted on
Thu Dec 28, 2017 2:36 pm
Colorado4Wheeler offline
User avatar
Posts: 2794
Joined: Jul 20, 2009
Location: Colorado

Re: Clearing deviceFIlter Attribute from Actions.xml

I know this is a year old but I just ran into this myself, it still requires a full relaunch of the client but not restarting the Indigo server, just whatever client you are using to get to Indigo and see this problem.

FYI.

My Modest Contributions to Indigo:

HomeKit Bridge | Device Extensions | Security Manager | LCD Creator | Room-O-Matic | Smart Dimmer | Scene Toggle | Powermiser | Homebridge Buddy

Check Them Out Here

Posted on
Fri Sep 28, 2018 1:29 pm
matt (support) offline
Site Admin
User avatar
Posts: 21417
Joined: Jan 27, 2003
Location: Texas

Re: Clearing deviceFIlter Attribute from Actions.xml

Indigo 7.2.0 is now available for download and you should now be able to just reload the plugin for all the attributes to be refreshed.

Image

Page 1 of 1

Who is online

Users browsing this forum: No registered users and 1 guest